Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support 'none' value for OTEL_METRICS_EXPORTER #801

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix: support 'none' value for OTEL_METRICS_EXPORTER #801

merged 1 commit into from
Sep 20, 2023

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Sep 20, 2023

The code was throwing when OTEL_METRICS_EXPORTER=none, but none is a valid value.

@seemk seemk requested review from a team as code owners September 20, 2023 12:13
@seemk seemk merged commit 8681bfc into main Sep 20, 2023
86 checks passed
@seemk seemk deleted the fix-none-exporters branch September 20, 2023 12:49
@seemk seemk mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhennoch mhennoch mhennoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seemk @mhennoch